Skip to content

Add netconf docker to build-image#19492

Open
hussamsh wants to merge 2 commits intosonic-net:masterfrom
hussamsh:master
Open

Add netconf docker to build-image#19492
hussamsh wants to merge 2 commits intosonic-net:masterfrom
hussamsh:master

Conversation

@hussamsh
Copy link
Copy Markdown

@hussamsh hussamsh commented Jul 5, 2024

Why I did it

I wanted to add NETCONF server support for configuring SONiC switches. Similar to the work done on RESTCONF server.

How I did it

First, the changes themselves are on the Official sonic netconf repositroy.
This work focuses on integrating the netconf server in build-image processes. I updated relevant build scripts , dockerfiles and git modules to include the netconf server in the final image.

How to verify it

  1. Normally build the image
  2. Install new image with netconf server on a switch. After switch stabilizes inspect the docker to see the netconf-server docker image is up.
  3. Test NETCONF connection using ssh <username>@<ip> -p 830 -s netconf

Description for the changelog

This change adds support for a RFC compliant NETCONF server for SONiC switches.

Implements sonic-net/SONiC#1466
Implements sonic-net/SONiC#1498
Uses sonic-net/sonic-netconf-server#2

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@hussamsh
Copy link
Copy Markdown
Author

hussamsh commented Jul 5, 2024

Hello @zhangyanzhao @aseaudi

This is the remaining part of the NETCONF server implementation, integration in the sonic-build-image.

For your info

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Pull request contains merge conflicts.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 19492 in repo sonic-net/sonic-buildimage

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

- Add sonic-netconf-server Git submodule
- Add Dockerfile and related configuration for netconf container
- Add systemd service and timer files for netconf server
- Add Makefile rules and dependencies for sonic-netconf-server

Signed-off-by: Hossam Hassan <hossam@hossamsherif.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Hossam Hassan <hossam@hossamsherif.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 Backlog (not in plan yet)

Development

Successfully merging this pull request may close these issues.

8 participants